3fd4949040
Self-review of the atomic-publish fix. Some network mounts and container volumes reject os.link, and the outer handler swallowed that into "no salt", which meant repo_hash and session_hash were dropped on every run for that whole cohort. The race being closed is narrow; losing the hashes for an entire filesystem is not a fair trade. Falls back to claiming the name with O_CREAT|O_EXCL and writing, which is what this did before. The empty-file window reopens there, but it is benign now: a reader landing in it gets "" and omits the hash for that process rather than caching a guessable path digest, which was the actual defect. 266 passed, 8 skipped. Claude-Session: https://claude.ai/code/session_01C7tEmH86HAr7GoAAKCEHZb
388 lines
14 KiB
Python
388 lines
14 KiB
Python
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
HOST_ROOT = Path(__file__).resolve().parents[1]
|
|
CORE = HOST_ROOT / "core"
|
|
sys.path.insert(0, str(CORE))
|
|
|
|
import memory_core # noqa: E402
|
|
import telemetry # noqa: E402
|
|
|
|
|
|
@pytest.fixture
|
|
def isolated_env(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("MEM0_CODE_DATA_DIR", str(tmp_path / "data"))
|
|
monkeypatch.setenv("MEM0_TELEMETRY", "true")
|
|
monkeypatch.delenv("MEM0_API_KEY", raising=False)
|
|
monkeypatch.delenv("CLAUDE_PLUGIN_OPTION_API_KEY", raising=False)
|
|
monkeypatch.delenv("CLAUDE_PLUGIN_OPTION_MEM0_API_KEY", raising=False)
|
|
monkeypatch.delenv("MEM0_API_URL", raising=False)
|
|
return tmp_path
|
|
|
|
|
|
def repo() -> memory_core.RepoContext:
|
|
return memory_core.RepoContext(
|
|
cwd="/tmp/repo",
|
|
root="/tmp/repo",
|
|
identity="https://github.com/example/secret-repo",
|
|
app_id="code-example",
|
|
branch="main",
|
|
head_sha="abc123",
|
|
)
|
|
|
|
|
|
def spool_lines() -> list[dict]:
|
|
path = memory_core.data_dir() / "telemetry.jsonl"
|
|
if not path.exists():
|
|
return []
|
|
return [json.loads(line) for line in path.read_text().splitlines()]
|
|
|
|
|
|
def test_opt_out_writes_nothing(isolated_env, monkeypatch):
|
|
for value in ("false", "0", "no", "OFF"):
|
|
monkeypatch.setenv("MEM0_TELEMETRY", value)
|
|
telemetry.record("search", repo=repo(), session_id="s-1")
|
|
assert not telemetry.is_enabled()
|
|
assert spool_lines() == []
|
|
|
|
|
|
def test_record_hashes_identifiers_and_keeps_no_content(isolated_env):
|
|
telemetry.record(
|
|
"search",
|
|
repo=repo(),
|
|
session_id="session-abcdef",
|
|
trigger="first-prompt-search",
|
|
matched_count=3,
|
|
dropped=None,
|
|
)
|
|
(event,) = spool_lines()
|
|
assert event["event"] == "code.search"
|
|
assert event["timestamp"]
|
|
properties = event["properties"]
|
|
assert properties["harness"] == "claude-code"
|
|
assert properties["plugin_version"] == memory_core.PLUGIN_VERSION
|
|
assert properties["matched_count"] == 3
|
|
assert "dropped" not in properties
|
|
assert len(properties["repo_hash"]) == 16
|
|
assert len(properties["session_hash"]) == 16
|
|
serialized = json.dumps(event)
|
|
assert "secret-repo" not in serialized
|
|
assert "session-abcdef" not in serialized
|
|
|
|
|
|
def test_record_rejects_sensitive_properties_at_the_shared_boundary(isolated_env):
|
|
secret = "sk-eval-12345678901234567890"
|
|
telemetry.record(
|
|
"search",
|
|
prompt=f"remember {secret}",
|
|
query=secret,
|
|
api_key=secret,
|
|
user_id="private-user",
|
|
note=f"failure contained {secret}",
|
|
memory_count=2,
|
|
)
|
|
|
|
(event,) = spool_lines()
|
|
assert event["properties"]["memory_count"] == 2
|
|
serialized = json.dumps(event)
|
|
assert secret not in serialized
|
|
assert "private-user" not in serialized
|
|
assert not {"prompt", "query", "api_key", "user_id"} & event["properties"].keys()
|
|
|
|
|
|
@pytest.mark.parametrize("key", ["password", "token", "secret", "authorization"])
|
|
def test_record_removes_sensitive_keys_from_nested_lists(isolated_env, key):
|
|
secret = "sk-eval-12345678901234567890"
|
|
telemetry.record(
|
|
"search",
|
|
details=[
|
|
{key: "plain-value", "count": 2},
|
|
{"nested": {key.upper(): "plain-value", "ok": True}},
|
|
[f"failure contained {secret}"],
|
|
],
|
|
)
|
|
|
|
(event,) = spool_lines()
|
|
assert event["properties"]["details"] == [
|
|
{"count": 2},
|
|
{"nested": {"ok": True}},
|
|
["failure contained [REDACTED]"],
|
|
]
|
|
|
|
|
|
def test_record_stops_appending_past_the_spool_cap(isolated_env):
|
|
spool = memory_core.data_dir() / "telemetry.jsonl"
|
|
spool.parent.mkdir(parents=True, exist_ok=True)
|
|
spool.write_text("x" * (telemetry.SPOOL_LIMIT_BYTES + 1))
|
|
telemetry.record("search")
|
|
assert spool.read_text() == "x" * (telemetry.SPOOL_LIMIT_BYTES + 1)
|
|
|
|
|
|
def test_record_never_raises_on_a_broken_spool(isolated_env, monkeypatch):
|
|
monkeypatch.setattr(telemetry, "_spool_path", lambda: Path("/does/not/exist/x"))
|
|
telemetry.record("search")
|
|
|
|
|
|
def test_error_kind_stays_coarse_and_content_free():
|
|
assert telemetry.error_kind("HTTP 429 too many requests") == "rate-limited"
|
|
assert telemetry.error_kind("HTTP 401 for /v1/memories/") == "auth"
|
|
assert telemetry.error_kind("HTTP 503 upstream") == "server-error"
|
|
assert telemetry.error_kind(TimeoutError("timed out")) == "timeout"
|
|
assert telemetry.error_kind(ValueError("token sk-abcdef leaked")) == "ValueError"
|
|
|
|
|
|
def test_flush_posts_one_batch_and_clears_the_spool(isolated_env):
|
|
telemetry.record("session_start")
|
|
telemetry.record("search", matched_count=1)
|
|
posted = []
|
|
|
|
with patch.object(telemetry, "_post", lambda payload, url: posted.append((payload, url)) or True):
|
|
assert telemetry.flush() == 2
|
|
|
|
(payload, url) = posted[0]
|
|
assert url == telemetry.POSTHOG_BATCH_URL
|
|
assert payload["api_key"] == telemetry.POSTHOG_API_KEY
|
|
assert [event["event"] for event in payload["batch"]] == [
|
|
"code.session_start",
|
|
"code.search",
|
|
]
|
|
first = payload["batch"][0]
|
|
assert first["distinct_id"].startswith("code-anon-")
|
|
assert first["properties"]["source"] == "CLAUDE_CODE_PLUGIN"
|
|
assert first["properties"]["$process_person_profile"] is False
|
|
assert not (memory_core.data_dir() / "telemetry.jsonl").exists()
|
|
assert not list(memory_core.data_dir().glob("telemetry-*.sending"))
|
|
|
|
|
|
def test_flush_chunks_batches(isolated_env):
|
|
for index in range(telemetry.BATCH_SIZE + 5):
|
|
telemetry.record("search", index=index)
|
|
sizes = []
|
|
|
|
with patch.object(
|
|
telemetry, "_post", lambda payload, url: sizes.append(len(payload["batch"])) or True
|
|
):
|
|
assert telemetry.flush() == telemetry.BATCH_SIZE + 5
|
|
|
|
assert sizes == [telemetry.BATCH_SIZE, 5]
|
|
|
|
|
|
def test_a_failed_post_keeps_the_events_for_the_next_run(isolated_env):
|
|
telemetry.record("search")
|
|
|
|
with patch.object(telemetry, "_post", lambda payload, url: False):
|
|
assert telemetry.flush() == 0
|
|
|
|
claims = list(memory_core.data_dir().glob("telemetry-*.sending"))
|
|
assert len(claims) == 1
|
|
assert json.loads(claims[0].read_text().splitlines()[0])["event"] == "code.search"
|
|
|
|
|
|
def test_a_claimed_spool_is_not_sent_twice(isolated_env):
|
|
telemetry.record("search")
|
|
first = telemetry._claim_spool()
|
|
assert first is not None
|
|
assert telemetry._claim_spool() is None
|
|
|
|
with patch.object(telemetry, "_post", lambda payload, url: True):
|
|
assert telemetry.flush() == 0
|
|
|
|
|
|
def test_a_stale_claim_is_reclaimed(isolated_env, monkeypatch):
|
|
telemetry.record("search")
|
|
orphan = telemetry._claim_spool()
|
|
assert orphan is not None
|
|
monkeypatch.setattr(
|
|
telemetry.time, "time", lambda: orphan.stat().st_mtime + telemetry.CLAIM_STALE_SECONDS + 1
|
|
)
|
|
|
|
with patch.object(telemetry, "_post", lambda payload, url: True):
|
|
assert telemetry.flush() == 1
|
|
|
|
|
|
def test_an_expired_claim_is_dropped(isolated_env, monkeypatch):
|
|
telemetry.record("search")
|
|
orphan = telemetry._claim_spool()
|
|
assert orphan is not None
|
|
monkeypatch.setattr(
|
|
telemetry.time, "time", lambda: orphan.stat().st_mtime + telemetry.CLAIM_EXPIRY_SECONDS + 1
|
|
)
|
|
assert telemetry._claim_spool() is None
|
|
assert not list(memory_core.data_dir().glob("telemetry-*.sending"))
|
|
|
|
|
|
def test_the_email_replaces_the_anonymous_id_once_and_is_aliased(isolated_env, monkeypatch):
|
|
monkeypatch.setenv("MEM0_API_KEY", "test-key")
|
|
anonymous = telemetry.anonymous_id()
|
|
telemetry.record("search")
|
|
posted = []
|
|
|
|
with (
|
|
patch.object(telemetry, "_resolve_email", lambda key: "dev@example.com"),
|
|
patch.object(telemetry, "_post", lambda payload, url: posted.append(payload) or True),
|
|
):
|
|
assert telemetry.flush() == 1
|
|
|
|
identify, batch = posted
|
|
assert identify["event"] == "$identify"
|
|
assert identify["distinct_id"] == "dev@example.com"
|
|
assert identify["properties"]["$anon_distinct_id"] == anonymous
|
|
assert batch["batch"][0]["distinct_id"] == "dev@example.com"
|
|
|
|
telemetry.record("search")
|
|
posted.clear()
|
|
with (
|
|
patch.object(telemetry, "_resolve_email", lambda key: pytest.fail("re-resolved")),
|
|
patch.object(telemetry, "_post", lambda payload, url: posted.append(payload) or True),
|
|
):
|
|
assert telemetry.flush() == 1
|
|
assert [payload.get("event") for payload in posted] == [None]
|
|
|
|
|
|
def test_an_unresolvable_key_falls_back_to_the_anonymous_id(isolated_env, monkeypatch):
|
|
monkeypatch.setenv("MEM0_API_KEY", "test-key")
|
|
telemetry.record("search")
|
|
|
|
with (
|
|
patch.object(telemetry, "_resolve_email", lambda key: ""),
|
|
patch.object(telemetry, "_post", lambda payload, url: True),
|
|
):
|
|
assert telemetry.flush() == 1
|
|
|
|
assert telemetry.resolve_distinct_id()[0].startswith("code-anon-")
|
|
|
|
|
|
def test_is_first_run_flips_after_the_first_identity_write(isolated_env):
|
|
assert telemetry.is_first_run()
|
|
telemetry.anonymous_id()
|
|
assert not telemetry.is_first_run()
|
|
|
|
|
|
def test_spawn_flush_does_nothing_without_a_spool(isolated_env):
|
|
with patch.object(telemetry.subprocess, "Popen") as popen:
|
|
assert telemetry.spawn_flush() is False
|
|
popen.assert_not_called()
|
|
|
|
telemetry.record("search")
|
|
with patch.object(telemetry.subprocess, "Popen") as popen:
|
|
assert telemetry.spawn_flush() is True
|
|
popen.assert_called_once()
|
|
|
|
|
|
def test_salt_is_stable_across_processes(isolated_env):
|
|
"""Hooks are separate short-lived processes; one repo must hash one way.
|
|
|
|
An unlocked read-modify-write let each process mint its own salt, so a
|
|
repository hashed several ways in the window before one writer won.
|
|
"""
|
|
import subprocess as sp
|
|
|
|
core = str(Path(__file__).resolve().parents[1] / "core")
|
|
script = (
|
|
f"import sys; sys.path.insert(0, {core!r})\n"
|
|
"import telemetry\n"
|
|
"print(telemetry._install_salt())"
|
|
)
|
|
env = {**os.environ, "MEM0_CODE_DATA_DIR": str(memory_core.data_dir())}
|
|
salts = {
|
|
sp.run([sys.executable, "-c", script], capture_output=True, text=True, env=env).stdout.strip()
|
|
for _ in range(4)
|
|
}
|
|
assert len(salts) == 1, f"one repo hashed {len(salts)} ways: {salts}"
|
|
|
|
|
|
def test_salt_does_not_touch_the_identity_file(isolated_env):
|
|
"""The identity file is is_first_run's marker and the sender's email store.
|
|
|
|
Writing the salt into it would create it from record(), suppressing the
|
|
install event, and would race resolve_distinct_id, which holds a stale copy
|
|
of that dict across a network call.
|
|
"""
|
|
telemetry._install_salt()
|
|
assert not telemetry._identity_path().exists()
|
|
|
|
|
|
def test_no_salt_means_no_hash_rather_than_an_unsalted_one(isolated_env, monkeypatch):
|
|
"""A read-only data dir drops the property; it must not emit a weak digest.
|
|
|
|
The previous fallback was a digest of the salt file's own path, which an
|
|
attacker can compute, memoized for the whole process. A property named
|
|
repo_hash carrying an effectively unsalted digest is worse than no property:
|
|
it reads as protected and is not.
|
|
"""
|
|
telemetry._salt_cache = ""
|
|
monkeypatch.setattr(telemetry.os, "open", lambda *a, **k: (_ for _ in ()).throw(OSError("read-only")))
|
|
|
|
assert telemetry._install_salt() == ""
|
|
assert telemetry._scoped_digest("git@github.com:acme/secret.git") == ""
|
|
|
|
|
|
def test_a_half_written_salt_is_never_visible_to_another_process(isolated_env, monkeypatch):
|
|
"""The window this closes: file created, value not yet written.
|
|
|
|
O_CREAT|O_EXCL then write leaves the name present and empty in between. A
|
|
hook reading it there used to get "", fall back to the path digest and cache
|
|
that for its whole run, so the same repo hashed two ways depending on timing.
|
|
Publishing by link means the name either does not exist or is complete.
|
|
"""
|
|
telemetry._salt_cache = ""
|
|
salt_path = telemetry._salt_path()
|
|
observed = []
|
|
|
|
real_link = telemetry.os.link
|
|
|
|
def observing_link(source, target):
|
|
# Stand where the racing reader stands: after the temp file is written,
|
|
# before the real name exists.
|
|
observed.append(salt_path.exists())
|
|
return real_link(source, target)
|
|
|
|
monkeypatch.setattr(telemetry.os, "link", observing_link)
|
|
salt = telemetry._install_salt()
|
|
|
|
assert observed == [False], "the salt name existed before it held a value"
|
|
assert len(salt) == 32
|
|
assert salt_path.read_text(encoding="utf-8").strip() == salt
|
|
|
|
|
|
def test_a_filesystem_without_hardlinks_still_gets_a_salt(isolated_env, monkeypatch):
|
|
"""Publishing by link must not become a silent loss of the hashes.
|
|
|
|
Some network mounts and container volumes reject os.link. Returning ""
|
|
there would drop repo_hash and session_hash on every run for that whole
|
|
cohort, which is a bigger loss than the narrow race the link closes.
|
|
"""
|
|
telemetry._salt_cache = ""
|
|
monkeypatch.setattr(
|
|
telemetry.os, "link", lambda src, dst: (_ for _ in ()).throw(OSError(38, "not implemented"))
|
|
)
|
|
|
|
salt = telemetry._install_salt()
|
|
|
|
assert len(salt) == 32, "no salt on a filesystem without hardlinks"
|
|
assert telemetry._salt_path().read_text(encoding="utf-8").strip() == salt
|
|
assert telemetry._scoped_digest("git@github.com:acme/x.git") != ""
|
|
assert not list(telemetry._salt_path().parent.glob("telemetry-salt.*.tmp"))
|
|
|
|
|
|
def test_a_concurrent_writer_does_not_clobber_the_published_salt(isolated_env):
|
|
"""Second process to finish must adopt the first one's salt, not replace it.
|
|
|
|
os.link rather than os.replace is what makes losing the race harmless.
|
|
"""
|
|
telemetry._salt_cache = ""
|
|
first = telemetry._install_salt()
|
|
|
|
telemetry._salt_cache = ""
|
|
second = telemetry._install_salt()
|
|
|
|
assert second == first
|
|
assert not list(telemetry._salt_path().parent.glob("telemetry-salt.*.tmp")), "temp file left behind"
|