fix(integrations): address review feedback on Zapier and n8n
Zapier: - Bound the poll budget under Zapier's step timeout and default Wait for Completion off; timeout message notes the add likely still succeeded - Add offline unit tests (mocked z.request) and run them in CI - Expose a Page input on Get Memories - Encode memory_id in the delete path - Update E2E to test the default no-wait path (add then search-retry) n8n: - Clarify the Infer description (controls extraction, not waiting) - Add an App ID field and require at least one entity id before add - Pass itemIndex into pollEvent errors - Unwrap event results so wait-path output matches search and get many
This commit is contained in:
@@ -3,9 +3,10 @@ name: zapier-mem0 checks
|
||||
# On PRs this is invoked by ci-gate.yml (the single required check);
|
||||
# push-to-main and manual runs remain standalone.
|
||||
#
|
||||
# CI runs `zapier validate` (offline schema + style checks). The end-to-end
|
||||
# jest suite is skipped here because it hits the live Mem0 API — it runs
|
||||
# locally with MEM0_API_KEY set (see the package README).
|
||||
# CI runs `zapier validate` (offline schema + style checks) plus the offline
|
||||
# jest unit suite (test/unit.test.js — mocked z.request, no network). The
|
||||
# end-to-end jest suite is skipped here because it hits the live Mem0 API — it
|
||||
# runs locally with MEM0_API_KEY set (see the package README).
|
||||
on:
|
||||
workflow_dispatch:
|
||||
push:
|
||||
@@ -38,3 +39,6 @@ jobs:
|
||||
|
||||
- name: Validate Zapier app definition
|
||||
run: cd integrations/zapier-mem0 && npx zapier-platform-cli@19 validate
|
||||
|
||||
- name: Run offline unit tests
|
||||
run: cd integrations/zapier-mem0 && pnpm test:unit
|
||||
|
||||
Reference in New Issue
Block a user