fix: skip telemetry vector store init when MEM0_TELEMETRY is disabled (#4351)
This commit is contained in:
+34
-33
@@ -24,7 +24,7 @@ from mem0.exceptions import ValidationError as Mem0ValidationError
|
|||||||
from mem0.memory.base import MemoryBase
|
from mem0.memory.base import MemoryBase
|
||||||
from mem0.memory.setup import mem0_dir, setup_config
|
from mem0.memory.setup import mem0_dir, setup_config
|
||||||
from mem0.memory.storage import SQLiteManager
|
from mem0.memory.storage import SQLiteManager
|
||||||
from mem0.memory.telemetry import capture_event
|
from mem0.memory.telemetry import MEM0_TELEMETRY, capture_event
|
||||||
from mem0.memory.utils import (
|
from mem0.memory.utils import (
|
||||||
extract_json,
|
extract_json,
|
||||||
get_fact_retrieval_messages,
|
get_fact_retrieval_messages,
|
||||||
@@ -37,8 +37,8 @@ from mem0.utils.factory import (
|
|||||||
EmbedderFactory,
|
EmbedderFactory,
|
||||||
GraphStoreFactory,
|
GraphStoreFactory,
|
||||||
LlmFactory,
|
LlmFactory,
|
||||||
VectorStoreFactory,
|
|
||||||
RerankerFactory,
|
RerankerFactory,
|
||||||
|
VectorStoreFactory,
|
||||||
)
|
)
|
||||||
|
|
||||||
# Suppress SWIG deprecation warnings globally
|
# Suppress SWIG deprecation warnings globally
|
||||||
@@ -204,32 +204,33 @@ class Memory(MemoryBase):
|
|||||||
self.enable_graph = True
|
self.enable_graph = True
|
||||||
else:
|
else:
|
||||||
self.graph = None
|
self.graph = None
|
||||||
# Create telemetry config manually to avoid deepcopy issues with thread locks
|
if MEM0_TELEMETRY:
|
||||||
telemetry_config_dict = {}
|
# Create telemetry config manually to avoid deepcopy issues with thread locks
|
||||||
if hasattr(self.config.vector_store.config, 'model_dump'):
|
telemetry_config_dict = {}
|
||||||
# For pydantic models
|
if hasattr(self.config.vector_store.config, 'model_dump'):
|
||||||
telemetry_config_dict = self.config.vector_store.config.model_dump()
|
# For pydantic models
|
||||||
else:
|
telemetry_config_dict = self.config.vector_store.config.model_dump()
|
||||||
# For other objects, manually copy common attributes
|
else:
|
||||||
for attr in ['host', 'port', 'path', 'api_key', 'index_name', 'dimension', 'metric']:
|
# For other objects, manually copy common attributes
|
||||||
if hasattr(self.config.vector_store.config, attr):
|
for attr in ['host', 'port', 'path', 'api_key', 'index_name', 'dimension', 'metric']:
|
||||||
telemetry_config_dict[attr] = getattr(self.config.vector_store.config, attr)
|
if hasattr(self.config.vector_store.config, attr):
|
||||||
|
telemetry_config_dict[attr] = getattr(self.config.vector_store.config, attr)
|
||||||
|
|
||||||
# Override collection name for telemetry
|
# Override collection name for telemetry
|
||||||
telemetry_config_dict['collection_name'] = "mem0migrations"
|
telemetry_config_dict['collection_name'] = "mem0migrations"
|
||||||
|
|
||||||
# Set path for file-based vector stores
|
# Set path for file-based vector stores
|
||||||
telemetry_config = _safe_deepcopy_config(self.config.vector_store.config)
|
telemetry_config = _safe_deepcopy_config(self.config.vector_store.config)
|
||||||
if self.config.vector_store.provider in ["faiss", "qdrant"]:
|
if self.config.vector_store.provider in ["faiss", "qdrant"]:
|
||||||
provider_path = f"migrations_{self.config.vector_store.provider}"
|
provider_path = f"migrations_{self.config.vector_store.provider}"
|
||||||
telemetry_config_dict['path'] = os.path.join(mem0_dir, provider_path)
|
telemetry_config_dict['path'] = os.path.join(mem0_dir, provider_path)
|
||||||
os.makedirs(telemetry_config_dict['path'], exist_ok=True)
|
os.makedirs(telemetry_config_dict['path'], exist_ok=True)
|
||||||
|
|
||||||
# Create the config object using the same class as the original
|
# Create the config object using the same class as the original
|
||||||
telemetry_config = self.config.vector_store.config.__class__(**telemetry_config_dict)
|
telemetry_config = self.config.vector_store.config.__class__(**telemetry_config_dict)
|
||||||
self._telemetry_vector_store = VectorStoreFactory.create(
|
self._telemetry_vector_store = VectorStoreFactory.create(
|
||||||
self.config.vector_store.provider, telemetry_config
|
self.config.vector_store.provider, telemetry_config
|
||||||
)
|
)
|
||||||
capture_event("mem0.init", self, {"sync_type": "sync"})
|
capture_event("mem0.init", self, {"sync_type": "sync"})
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
@@ -1272,14 +1273,14 @@ class AsyncMemory(MemoryBase):
|
|||||||
else:
|
else:
|
||||||
self.graph = None
|
self.graph = None
|
||||||
|
|
||||||
telemetry_config = _safe_deepcopy_config(self.config.vector_store.config)
|
if MEM0_TELEMETRY:
|
||||||
telemetry_config.collection_name = "mem0migrations"
|
telemetry_config = _safe_deepcopy_config(self.config.vector_store.config)
|
||||||
if self.config.vector_store.provider in ["faiss", "qdrant"]:
|
telemetry_config.collection_name = "mem0migrations"
|
||||||
provider_path = f"migrations_{self.config.vector_store.provider}"
|
if self.config.vector_store.provider in ["faiss", "qdrant"]:
|
||||||
telemetry_config.path = os.path.join(mem0_dir, provider_path)
|
provider_path = f"migrations_{self.config.vector_store.provider}"
|
||||||
os.makedirs(telemetry_config.path, exist_ok=True)
|
telemetry_config.path = os.path.join(mem0_dir, provider_path)
|
||||||
self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config)
|
os.makedirs(telemetry_config.path, exist_ok=True)
|
||||||
|
self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config)
|
||||||
capture_event("mem0.init", self, {"sync_type": "async"})
|
capture_event("mem0.init", self, {"sync_type": "async"})
|
||||||
|
|
||||||
@classmethod
|
@classmethod
|
||||||
|
|||||||
@@ -296,3 +296,43 @@ def test_custom_prompts(memory_custom_instance):
|
|||||||
messages=[{"role": "user", "content": mock_get_update_memory_messages.return_value}],
|
messages=[{"role": "user", "content": mock_get_update_memory_messages.return_value}],
|
||||||
response_format={"type": "json_object"},
|
response_format={"type": "json_object"},
|
||||||
)
|
)
|
||||||
|
|
||||||
|
|
||||||
|
def test_no_telemetry_vector_store_when_disabled():
|
||||||
|
"""VectorStoreFactory should only be called once (for user data) when telemetry is disabled."""
|
||||||
|
with (
|
||||||
|
patch("mem0.memory.main.MEM0_TELEMETRY", False),
|
||||||
|
patch("mem0.utils.factory.EmbedderFactory") as mock_embedder,
|
||||||
|
patch("mem0.memory.main.VectorStoreFactory") as mock_vector_store,
|
||||||
|
patch("mem0.utils.factory.LlmFactory") as mock_llm,
|
||||||
|
patch("mem0.memory.telemetry.capture_event"),
|
||||||
|
):
|
||||||
|
mock_embedder.create.return_value = Mock()
|
||||||
|
mock_vector_store.create.return_value = Mock()
|
||||||
|
mock_llm.create.return_value = Mock()
|
||||||
|
|
||||||
|
config = MemoryConfig(version="v1.1")
|
||||||
|
Memory(config)
|
||||||
|
|
||||||
|
# VectorStoreFactory.create should be called exactly once — for user data only, not telemetry
|
||||||
|
assert mock_vector_store.create.call_count == 1
|
||||||
|
|
||||||
|
|
||||||
|
def test_telemetry_vector_store_created_when_enabled():
|
||||||
|
"""VectorStoreFactory should be called twice (user data + telemetry) when telemetry is enabled."""
|
||||||
|
with (
|
||||||
|
patch("mem0.memory.main.MEM0_TELEMETRY", True),
|
||||||
|
patch("mem0.utils.factory.EmbedderFactory") as mock_embedder,
|
||||||
|
patch("mem0.memory.main.VectorStoreFactory") as mock_vector_store,
|
||||||
|
patch("mem0.utils.factory.LlmFactory") as mock_llm,
|
||||||
|
patch("mem0.memory.telemetry.capture_event"),
|
||||||
|
):
|
||||||
|
mock_embedder.create.return_value = Mock()
|
||||||
|
mock_vector_store.create.return_value = Mock()
|
||||||
|
mock_llm.create.return_value = Mock()
|
||||||
|
|
||||||
|
config = MemoryConfig(version="v1.1")
|
||||||
|
Memory(config)
|
||||||
|
|
||||||
|
# VectorStoreFactory.create should be called twice — user data + telemetry
|
||||||
|
assert mock_vector_store.create.call_count == 2
|
||||||
|
|||||||
Reference in New Issue
Block a user