fix: skip telemetry vector store init when MEM0_TELEMETRY is disabled (#4351)

This commit is contained in:
Kartik
2026-03-16 20:55:04 +05:30
committed by GitHub
parent 2e5e290434
commit 8fcf2b0b29
2 changed files with 74 additions and 33 deletions
+4 -3
View File
@@ -24,7 +24,7 @@ from mem0.exceptions import ValidationError as Mem0ValidationError
from mem0.memory.base import MemoryBase from mem0.memory.base import MemoryBase
from mem0.memory.setup import mem0_dir, setup_config from mem0.memory.setup import mem0_dir, setup_config
from mem0.memory.storage import SQLiteManager from mem0.memory.storage import SQLiteManager
from mem0.memory.telemetry import capture_event from mem0.memory.telemetry import MEM0_TELEMETRY, capture_event
from mem0.memory.utils import ( from mem0.memory.utils import (
extract_json, extract_json,
get_fact_retrieval_messages, get_fact_retrieval_messages,
@@ -37,8 +37,8 @@ from mem0.utils.factory import (
EmbedderFactory, EmbedderFactory,
GraphStoreFactory, GraphStoreFactory,
LlmFactory, LlmFactory,
VectorStoreFactory,
RerankerFactory, RerankerFactory,
VectorStoreFactory,
) )
# Suppress SWIG deprecation warnings globally # Suppress SWIG deprecation warnings globally
@@ -204,6 +204,7 @@ class Memory(MemoryBase):
self.enable_graph = True self.enable_graph = True
else: else:
self.graph = None self.graph = None
if MEM0_TELEMETRY:
# Create telemetry config manually to avoid deepcopy issues with thread locks # Create telemetry config manually to avoid deepcopy issues with thread locks
telemetry_config_dict = {} telemetry_config_dict = {}
if hasattr(self.config.vector_store.config, 'model_dump'): if hasattr(self.config.vector_store.config, 'model_dump'):
@@ -1272,6 +1273,7 @@ class AsyncMemory(MemoryBase):
else: else:
self.graph = None self.graph = None
if MEM0_TELEMETRY:
telemetry_config = _safe_deepcopy_config(self.config.vector_store.config) telemetry_config = _safe_deepcopy_config(self.config.vector_store.config)
telemetry_config.collection_name = "mem0migrations" telemetry_config.collection_name = "mem0migrations"
if self.config.vector_store.provider in ["faiss", "qdrant"]: if self.config.vector_store.provider in ["faiss", "qdrant"]:
@@ -1279,7 +1281,6 @@ class AsyncMemory(MemoryBase):
telemetry_config.path = os.path.join(mem0_dir, provider_path) telemetry_config.path = os.path.join(mem0_dir, provider_path)
os.makedirs(telemetry_config.path, exist_ok=True) os.makedirs(telemetry_config.path, exist_ok=True)
self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config) self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config)
capture_event("mem0.init", self, {"sync_type": "async"}) capture_event("mem0.init", self, {"sync_type": "async"})
@classmethod @classmethod
+40
View File
@@ -296,3 +296,43 @@ def test_custom_prompts(memory_custom_instance):
messages=[{"role": "user", "content": mock_get_update_memory_messages.return_value}], messages=[{"role": "user", "content": mock_get_update_memory_messages.return_value}],
response_format={"type": "json_object"}, response_format={"type": "json_object"},
) )
def test_no_telemetry_vector_store_when_disabled():
"""VectorStoreFactory should only be called once (for user data) when telemetry is disabled."""
with (
patch("mem0.memory.main.MEM0_TELEMETRY", False),
patch("mem0.utils.factory.EmbedderFactory") as mock_embedder,
patch("mem0.memory.main.VectorStoreFactory") as mock_vector_store,
patch("mem0.utils.factory.LlmFactory") as mock_llm,
patch("mem0.memory.telemetry.capture_event"),
):
mock_embedder.create.return_value = Mock()
mock_vector_store.create.return_value = Mock()
mock_llm.create.return_value = Mock()
config = MemoryConfig(version="v1.1")
Memory(config)
# VectorStoreFactory.create should be called exactly once — for user data only, not telemetry
assert mock_vector_store.create.call_count == 1
def test_telemetry_vector_store_created_when_enabled():
"""VectorStoreFactory should be called twice (user data + telemetry) when telemetry is enabled."""
with (
patch("mem0.memory.main.MEM0_TELEMETRY", True),
patch("mem0.utils.factory.EmbedderFactory") as mock_embedder,
patch("mem0.memory.main.VectorStoreFactory") as mock_vector_store,
patch("mem0.utils.factory.LlmFactory") as mock_llm,
patch("mem0.memory.telemetry.capture_event"),
):
mock_embedder.create.return_value = Mock()
mock_vector_store.create.return_value = Mock()
mock_llm.create.return_value = Mock()
config = MemoryConfig(version="v1.1")
Memory(config)
# VectorStoreFactory.create should be called twice — user data + telemetry
assert mock_vector_store.create.call_count == 2