fix(server): do not forward empty-string entity ids as filters (#5992)
Co-authored-by: Kartik <kartik.labhshetwar@mem0.ai>
This commit is contained in:
+3
-3
@@ -426,7 +426,7 @@ def get_all_memories(
|
|||||||
# Admin all-memory listing is intentionally raw; scoped get_all below applies expiry visibility.
|
# Admin all-memory listing is intentionally raw; scoped get_all below applies expiry visibility.
|
||||||
return _list_all_memories(limit=top_k if top_k is not None else ALL_MEMORIES_LIMIT)
|
return _list_all_memories(limit=top_k if top_k is not None else ALL_MEMORIES_LIMIT)
|
||||||
filters = {
|
filters = {
|
||||||
k: v for k, v in {"user_id": user_id, "run_id": run_id, "agent_id": agent_id}.items() if v is not None
|
k: v for k, v in {"user_id": user_id, "run_id": run_id, "agent_id": agent_id}.items() if v
|
||||||
}
|
}
|
||||||
params = {"filters": filters}
|
params = {"filters": filters}
|
||||||
if top_k is not None:
|
if top_k is not None:
|
||||||
@@ -456,7 +456,7 @@ def search_memories(search_req: SearchRequest, _auth=Depends(verify_auth)):
|
|||||||
deprecated_keys = []
|
deprecated_keys = []
|
||||||
for entity_key in ("user_id", "agent_id", "run_id"):
|
for entity_key in ("user_id", "agent_id", "run_id"):
|
||||||
entity_val = getattr(search_req, entity_key, None)
|
entity_val = getattr(search_req, entity_key, None)
|
||||||
if entity_val is not None:
|
if entity_val:
|
||||||
filters[entity_key] = entity_val
|
filters[entity_key] = entity_val
|
||||||
deprecated_keys.append(entity_key)
|
deprecated_keys.append(entity_key)
|
||||||
if deprecated_keys:
|
if deprecated_keys:
|
||||||
@@ -535,7 +535,7 @@ def delete_all_memories(
|
|||||||
raise HTTPException(status_code=400, detail="At least one identifier is required.")
|
raise HTTPException(status_code=400, detail="At least one identifier is required.")
|
||||||
try:
|
try:
|
||||||
params = {
|
params = {
|
||||||
k: v for k, v in {"user_id": user_id, "run_id": run_id, "agent_id": agent_id}.items() if v is not None
|
k: v for k, v in {"user_id": user_id, "run_id": run_id, "agent_id": agent_id}.items() if v
|
||||||
}
|
}
|
||||||
get_memory_instance().delete_all(**params)
|
get_memory_instance().delete_all(**params)
|
||||||
return MessageResponse(message="All relevant memories deleted")
|
return MessageResponse(message="All relevant memories deleted")
|
||||||
|
|||||||
Reference in New Issue
Block a user