fix: remove destructive vector_store.reset() from delete_all() (#4349)

2026-03-16 20:55:29 +05:30
parent 8fcf2b0b29
commit 82d67430dd
2 changed files with 4 additions and 2 deletions
@@ -196,12 +196,15 @@ def test_delete_all(memory_instance, version, enable_graph):
    memory_instance.enable_graph = enable_graph
    mock_memories = [Mock(id="1"), Mock(id="2")]
    memory_instance.vector_store.list = Mock(return_value=(mock_memories, None))
+    memory_instance.vector_store.reset = Mock()
    memory_instance._delete_memory = Mock()
    memory_instance.graph.delete_all = Mock()

    result = memory_instance.delete_all(user_id="test_user")

    assert memory_instance._delete_memory.call_count == 2
+    # Ensure the collection is NOT dropped — only matched memories should be removed
+    memory_instance.vector_store.reset.assert_not_called()

    if enable_graph:
        memory_instance.graph.delete_all.assert_called_once_with({"user_id": "test_user"})