fix(eve): address review — async-write status, reasoning filter, turn-bounded capture, best-effort dedup
Review by @kartik-mem0. Root cause across all four: Mem0's hosted add with
infer:true is async and returns a PENDING event before the memory is visible.
- store.ts/tools.ts: add() returns AddResult{status,eventId} via parseAddResult;
the v3 add path returns {status:"PENDING", event_id}, so remember reports
{status:"queued", eventId} for async writes and {status:"saved"} only when
resolved. FAILED/unknown status maps to completed, not queued.
- messages.ts: drop typed non-text parts (reasoning no longer leaks into memory);
bound the captured assistant reply to the current turn and collect all of its
text segments (text->tool->text) instead of a stale prior answer.
- capture.ts + README + eve.mdx: document operationId dedup as best-effort
(lookup+add is not atomic; pending/concurrent windows can double-write);
removed the "restart replays cannot write twice" claim.
Tests: 68 pass (+15). Added reasoning, tool-only/cross-turn, multi-segment,
pending/concurrent capture replay, and PENDING/FAILED add-result cases.
Typecheck + build clean.
This commit is contained in:
@@ -27,6 +27,19 @@ describe("extractText", () => {
|
||||
it("ignores non-text parts", () => {
|
||||
expect(extractText([{ type: "image", url: "x" }])).toBe("");
|
||||
});
|
||||
|
||||
it("ignores reasoning parts and keeps only the final text", () => {
|
||||
expect(
|
||||
extractText([
|
||||
{ type: "reasoning", text: "speculation" },
|
||||
{ type: "text", text: "Noted." },
|
||||
]),
|
||||
).toBe("Noted.");
|
||||
});
|
||||
|
||||
it("still reads an untyped text object", () => {
|
||||
expect(extractText({ text: " bare " })).toBe("bare");
|
||||
});
|
||||
});
|
||||
|
||||
describe("lastUserText", () => {
|
||||
@@ -87,4 +100,54 @@ describe("completedTurnMessages", () => {
|
||||
}),
|
||||
).toEqual([]);
|
||||
});
|
||||
|
||||
it("does not attach a previous turn's answer to a tool-only turn", () => {
|
||||
// Older Q&A, then a new user message whose only assistant output is a
|
||||
// tool call (no text). The stale "older reply" must not be captured.
|
||||
expect(
|
||||
completedTurnMessages({
|
||||
turnInput: [{ role: "user", content: "new question" }],
|
||||
messages: [
|
||||
{ role: "user", content: "older question" },
|
||||
{ role: "assistant", content: "older reply" },
|
||||
{ role: "user", content: "new question" },
|
||||
{ role: "assistant", content: [{ type: "tool-call", id: "t1" }] },
|
||||
],
|
||||
}),
|
||||
).toEqual([{ role: "user", content: "new question" }]);
|
||||
});
|
||||
|
||||
it("captures all assistant text in a text/tool-call/text turn", () => {
|
||||
expect(
|
||||
completedTurnMessages({
|
||||
turnInput: [{ role: "user", content: "Q" }],
|
||||
messages: [
|
||||
{ role: "user", content: "Q" },
|
||||
{ role: "assistant", content: "part A" },
|
||||
{ role: "assistant", content: [{ type: "tool-call", id: "t1" }] },
|
||||
{ role: "assistant", content: "part B" },
|
||||
],
|
||||
}),
|
||||
).toEqual([
|
||||
{ role: "user", content: "Q" },
|
||||
{ role: "assistant", content: "part A\npart B" },
|
||||
]);
|
||||
});
|
||||
|
||||
it("captures this turn's assistant reply, not an earlier one", () => {
|
||||
expect(
|
||||
completedTurnMessages({
|
||||
turnInput: [{ role: "user", content: "new question" }],
|
||||
messages: [
|
||||
{ role: "user", content: "older question" },
|
||||
{ role: "assistant", content: "older reply" },
|
||||
{ role: "user", content: "new question" },
|
||||
{ role: "assistant", content: "new reply" },
|
||||
],
|
||||
}),
|
||||
).toEqual([
|
||||
{ role: "user", content: "new question" },
|
||||
{ role: "assistant", content: "new reply" },
|
||||
]);
|
||||
});
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user