fix(n8n): address review feedback and pass the verification scanner

- Telemetry: replace client-side PostHog (which read process.env, banned in verified nodes) with first-party `source: "N8N"` attribution on API requests, mirroring OpenClaw. Removes the undisclosed-collection concern entirely. - Verification-scanner fixes: add credential icon, use NodeConnectionTypes.Main instead of the 'main' literal, wrap error paths in NodeApiError, stop shipping .d.ts / tsbuildinfo, and align the local eslint config with the scanner. - Add offline unit tests (jest): entity-id guard, JSON-parse errors, poll-timeout loop, source attribution, and Return All pagination. - Get Many: add a Return All option that pages through all memories. - Docs: README telemetry note and an AGENTS.md Key Directories row. Verified: build + tsc + eslint + 5 unit tests + live E2E against api.mem0.ai, and the packed tarball passes @n8n/scan-community-package with zero violations.
2026-07-23 19:34:00 +05:30
parent 41a9701d7f
commit 7417f87252
12 changed files with 2261 additions and 61 deletions
@@ -0,0 +1,107 @@
+// Offline unit tests: they stub IExecuteFunctions and mock the HTTP layer, so
+// they run with no network. They cover the review-flagged paths: the entity-id
+// guard, JSON-parse errors, the poll-timeout loop, plus source attribution and
+// the Return All pagination.
+
+// Make the poll loop instant (pollEvent sleeps between attempts).
+jest.mock('n8n-workflow', () => {
+	const actual = jest.requireActual('n8n-workflow');
+	return { ...actual, sleep: jest.fn().mockResolvedValue(undefined) };
+});
+
+import { Mem0 } from '../nodes/Mem0/Mem0.node';
+
+type HttpImpl = (options: any) => Promise<any>;
+
+function makeCtx(
+	operation: string,
+	params: Record<string, any>,
+	http: HttpImpl,
+	opts: { continueOnFail?: boolean } = {},
+): any {
+	const requests: any[] = [];
+	const node = { name: 'Mem0', type: 'n8n-nodes-mem0.mem0', typeVersion: 1 };
+	const ctx: any = {
+		getInputData: () => [{ json: {} }],
+		getCredentials: async () => ({ apiKey: 'm0-test', baseUrl: 'https://api.mem0.ai' }),
+		getNodeParameter: (name: string, _i: number, dflt?: any) =>
+			name === 'operation' ? operation : name in params ? params[name] : dflt,
+		getNode: () => node,
+		continueOnFail: () => opts.continueOnFail ?? false,
+		helpers: {
+			httpRequestWithAuthentication: jest.fn(async function (_cred: string, options: any) {
+				requests.push(options);
+				return http(options);
+			}),
+		},
+	};
+	ctx.requests = requests;
+	return ctx;
+}
+
+const run = (ctx: any) => Mem0.prototype.execute.call(ctx);
+
+describe('Mem0 node (offline)', () => {
+	it('reports a clear error when Add has no entity id', async () => {
+		const ctx = makeCtx(
+			'add',
+			{ 'messages.message': [{ role: 'user', content: 'hi' }], addFields: {}, userId: '' },
+			async () => ({}),
+			{ continueOnFail: true },
+		);
+		const out: any = await run(ctx);
+		expect(out[0][0].json.error).toMatch(/at least one of User ID/i);
+	});
+
+	it('reports a clear error on invalid JSON in Custom Categories', async () => {
+		const ctx = makeCtx(
+			'add',
+			{
+				'messages.message': [{ role: 'user', content: 'hi' }],
+				addFields: { custom_categories: '{bad' },
+				userId: 'u1',
+			},
+			async () => ({}),
+			{ continueOnFail: true },
+		);
+		const out: any = await run(ctx);
+		expect(out[0][0].json.error).toMatch(/Invalid JSON/i);
+	});
+
+	it('times out when the add event never resolves', async () => {
+		const ctx = makeCtx(
+			'add',
+			{
+				'messages.message': [{ role: 'user', content: 'hi' }],
+				addFields: {},
+				userId: 'u1',
+				waitForCompletion: true,
+			},
+			async (options) => {
+				if (options.url.includes('/v3/memories/add/')) return { event_id: 'e1', status: 'PENDING' };
+				if (options.url.includes('/v1/event/')) return { status: 'PENDING' }; // never terminal
+				return {};
+			},
+			{ continueOnFail: true },
+		);
+		const out: any = await run(ctx);
+		expect(out[0][0].json.error).toMatch(/Timed out waiting for memory event/i);
+	});
+
+	it('tags every request with source=N8N for first-party attribution', async () => {
+		const ctx = makeCtx('search', { query: 'x', userId: 'u1', limit: 5 }, async () => ({ results: [] }));
+		await run(ctx);
+		expect(ctx.requests[0].qs.source).toBe('N8N');
+	});
+
+	it('Return All pages through until a short page', async () => {
+		let call = 0;
+		const ctx = makeCtx('getAll', { userId: 'u1', returnAll: true, pageSize: 2 }, async () => {
+			call++;
+			if (call === 1) return { results: [{ id: 'a' }, { id: 'b' }], next: 'page2' };
+			return { results: [{ id: 'c' }], next: null }; // short page -> stop
+		});
+		const out: any = await run(ctx);
+		expect(out[0].map((d: any) => d.json.id)).toEqual(['a', 'b', 'c']);
+	});
+});