JDSS/mem0
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: update search tests to use AND filter syntax and drop version param

Browse Source
This commit is contained in:
kartik-mem0
2026-04-14 17:46:58 +05:30
parent c3f48d093e
commit 5e941e24c2
2 changed files with 10 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mem0-ts/src/client/tests/memoryClient.search.test.ts
+2 -2
View File
@@ -189,7 +189,7 @@ describe("MemoryClient - search()", () => {
const client = new MemoryClient({ apiKey: TEST_API_KEY }); const client = new MemoryClient({ apiKey: TEST_API_KEY });
const result = await client.search("nonexistent query", { const result = await client.search("nonexistent query", {
filters: { user_id: "u1" }, filters: { AND: [{ user_id: "u1" }] },
}); });
expect(result.results).toHaveLength(0); expect(result.results).toHaveLength(0);
}); });
@@ -230,7 +230,7 @@ describe("MemoryClient - search() entity param rejection", () => {
const client = new MemoryClient({ apiKey: TEST_API_KEY }); const client = new MemoryClient({ apiKey: TEST_API_KEY });
// Should not throw // Should not throw
await client.search("query", { filters: { user_id: "u1" } }); await client.search("query", { filters: { AND: [{ user_id: "u1" }] } });
expect(findFetchCall(mock, "/v3/memories/search/", "POST")).toBeDefined(); expect(findFetchCall(mock, "/v3/memories/search/", "POST")).toBeDefined();
}); });
}); });
tests/test_main.py
+8 -24
View File
@@ -52,9 +52,7 @@ def memory_custom_instance():
return Memory(config) return Memory(config)
@pytest.mark.parametrize("version", ["v1.0", "v1.1"]) def test_add(memory_instance):
def test_add(memory_instance, version):
memory_instance.config.version = version
memory_instance._add_to_vector_store = Mock(return_value=[{"memory": "Test memory", "event": "ADD"}]) memory_instance._add_to_vector_store = Mock(return_value=[{"memory": "Test memory", "event": "ADD"}])
result = memory_instance.add(messages=[{"role": "user", "content": "Test message"}], user_id="test_user") result = memory_instance.add(messages=[{"role": "user", "content": "Test message"}], user_id="test_user")
@@ -92,9 +90,7 @@ def test_get(memory_instance):
assert result["metadata"] == {"extra_field": "extra_value"} assert result["metadata"] == {"extra_field": "extra_value"}
@pytest.mark.parametrize("version", ["v1.0", "v1.1"]) def test_search(memory_instance):
def test_search(memory_instance, version):
memory_instance.config.version = version
mock_memories = [ mock_memories = [
Mock(id="1", payload={"data": "Memory 1", "user_id": "test_user"}, score=0.9), Mock(id="1", payload={"data": "Memory 1", "user_id": "test_user"}, score=0.9),
Mock(id="2", payload={"data": "Memory 2", "user_id": "test_user"}, score=0.8), Mock(id="2", payload={"data": "Memory 2", "user_id": "test_user"}, score=0.8),
@@ -177,9 +173,7 @@ def test_delete(memory_instance):
assert result["message"] == "Memory deleted successfully!" assert result["message"] == "Memory deleted successfully!"
@pytest.mark.parametrize("version", ["v1.0", "v1.1"]) def test_delete_all(memory_instance):
def test_delete_all(memory_instance, version):
memory_instance.config.version = version
mock_memories = [Mock(id="1"), Mock(id="2")] mock_memories = [Mock(id="1"), Mock(id="2")]
memory_instance.vector_store.list = Mock(return_value=(mock_memories, None)) memory_instance.vector_store.list = Mock(return_value=(mock_memories, None))
memory_instance.vector_store.reset = Mock() memory_instance.vector_store.reset = Mock()
@@ -194,15 +188,7 @@ def test_delete_all(memory_instance, version):
assert result["message"] == "Memories deleted successfully!" assert result["message"] == "Memories deleted successfully!"
@pytest.mark.parametrize( def test_get_all(memory_instance):
"version, expected_result",
[
("v1.0", {"results": [{"id": "1", "memory": "Memory 1", "user_id": "test_user"}]}),
("v1.1", {"results": [{"id": "1", "memory": "Memory 1", "user_id": "test_user"}]}),
],
)
def test_get_all(memory_instance, version, expected_result):
memory_instance.config.version = version
mock_memories = [Mock(id="1", payload={"data": "Memory 1", "user_id": "test_user"})] mock_memories = [Mock(id="1", payload={"data": "Memory 1", "user_id": "test_user"})]
memory_instance.vector_store.list = Mock(return_value=(mock_memories, None)) memory_instance.vector_store.list = Mock(return_value=(mock_memories, None))
@@ -210,12 +196,10 @@ def test_get_all(memory_instance, version, expected_result):
assert isinstance(result, dict) assert isinstance(result, dict)
assert "results" in result assert "results" in result
assert len(result["results"]) == len(expected_result["results"]) assert len(result["results"]) == 1
for expected_item, result_item in zip(expected_result["results"], result["results"]): assert result["results"][0]["id"] == "1"
assert all(key in result_item for key in expected_item) assert result["results"][0]["memory"] == "Memory 1"
assert result_item["id"] == expected_item["id"] assert result["results"][0]["user_id"] == "test_user"
assert result_item["memory"] == expected_item["memory"]
assert result_item["user_id"] == expected_item["user_id"]
memory_instance.vector_store.list.assert_called_once_with(filters={"user_id": "test_user"}, top_k=100) memory_instance.vector_store.list.assert_called_once_with(filters={"user_id": "test_user"}, top_k=100)