fix(milvus,baidu): sanitize filter values to prevent expression injection (#5746)

This commit is contained in:
Hrushikesh Yadav
2026-06-23 16:51:05 +05:30
committed by GitHub
parent c0ac9f81fa
commit 565db27121
4 changed files with 85 additions and 4 deletions
+32
View File
@@ -235,3 +235,35 @@ def test_col_info(mochow_instance, mock_mochow_client):
result = mochow_instance.col_info()
assert result == mock_table_info
def test_create_filter_rejects_dict_value(mochow_instance):
"""Dict filter values could contain expression injection payloads."""
with pytest.raises(ValueError, match="must be str, int, float, or bool"):
mochow_instance._create_filter({"user_id": {"$ne": ""}})
def test_create_filter_rejects_malicious_key(mochow_instance):
"""Keys with special characters must be rejected."""
with pytest.raises(ValueError, match="Invalid filter key"):
mochow_instance._create_filter({'"] = "") or true or ("': "x"})
def test_create_filter_escapes_quotes_in_value(mochow_instance):
"""Double-quotes inside string values must be escaped."""
result = mochow_instance._create_filter({"user_id": 'alice"}'})
assert '\\"' in result
assert 'alice\\"' in result
def test_create_filter_escapes_backslash_and_quote(mochow_instance):
"""Backslashes and double-quotes in the same value must both be escaped."""
result = mochow_instance._create_filter({"user_id": r'alice\path"beta'})
assert result == r'metadata["user_id"] = "alice\\path\"beta"'
def test_create_filter_renders_boolean(mochow_instance):
"""Boolean values must be rendered unquoted in the backend's expected format."""
result = mochow_instance._create_filter({"active": True, "deleted": False})
assert 'metadata["active"] = True' in result
assert 'metadata["deleted"] = False' in result