JDSS/mem0
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(ts-oss, py): release Oracle client on init failure, validate insert batches (#6839)

Browse Source
This commit is contained in:
Kartik
2026-08-06 18:16:25 +05:30
committed by GitHub
parent beea626f0a
commit 4a0a9a92a6
4 changed files with 145 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mem0/vector_stores/oracledb.py
+26 -17
View File
@@ -245,25 +245,34 @@ class OracleAIVectorSearch(VectorStoreBase):
self.client = oracledb.connect(**self.config.connection_params)
self._owns_client = True
if not (hasattr(self.client, "thin") and self.client.thin):
if oracledb.clientversion()[:2] < (23, 4):
raise RuntimeError(
f"Oracle DB client driver version {'.'.join(map(str, oracledb.clientversion()))} "
"not supported, must be >=23.4 for vector support"
try:
if not (hasattr(self.client, "thin") and self.client.thin):
if oracledb.clientversion()[:2] < (23, 4):
raise RuntimeError(
f"Oracle DB client driver version {'.'.join(map(str, oracledb.clientversion()))} "
"not supported, must be >=23.4 for vector support"
)
if isinstance(self.client, oracledb.Connection):
db_version = tuple([int(v) for v in self.client.version.split(".")])
else:
with self.client.acquire() as conn:
db_version = tuple([int(v) for v in conn.version.split(".")])
if db_version < (23, 4):
raise ValueError(
f"Oracle DB version {'.'.join(map(str, db_version))} not supported, "
"must be >=23.4 for vector support"
)
if isinstance(self.client, oracledb.Connection):
db_version = tuple([int(v) for v in self.client.version.split(".")])
else:
with self.client.acquire() as conn:
db_version = tuple([int(v) for v in conn.version.split(".")])
if db_version < (23, 4):
raise ValueError(
f"Oracle DB version {'.'.join(map(str, db_version))} not supported, must be >=23.4 for vector support"
)
self.create_col()
self.create_col()
except Exception:
if self._owns_client:
try:
self.client.close()
except Exception:
pass
raise
@contextmanager
def _get_cursor(self, commit: bool = False):