feat(embeddings): add native embed_batch to 5 embedders (LMStudio, Together, HuggingFace, VertexAI, GoogleGenAI) (#5609)
This commit is contained in:
@@ -58,3 +58,62 @@ def test_config_initialization(config):
|
||||
assert embedder.config.api_key == "dummy_api_key"
|
||||
assert embedder.config.model == "test_model"
|
||||
assert embedder.config.embedding_dims == 786
|
||||
|
||||
|
||||
def test_embed_batch_single_call(mock_genai, config):
|
||||
emb0 = type("Embedding", (), {"values": [0.1, 0.2, 0.3]})()
|
||||
emb1 = type("Embedding", (), {"values": [0.4, 0.5, 0.6]})()
|
||||
mock_genai.return_value = type("Response", (), {"embeddings": [emb0, emb1]})()
|
||||
|
||||
embedder = GoogleGenAIEmbedding(config)
|
||||
|
||||
texts = ["First text.", "Second text."]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
mock_genai.assert_called_once_with(model="test_model", contents=texts, config=ANY)
|
||||
assert result == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
def test_embed_batch_empty_list(mock_genai, config):
|
||||
embedder = GoogleGenAIEmbedding(config)
|
||||
|
||||
result = embedder.embed_batch([])
|
||||
|
||||
assert result == []
|
||||
mock_genai.assert_not_called()
|
||||
|
||||
|
||||
def test_embed_batch_count_mismatch_raises(mock_genai, config):
|
||||
emb0 = type("Embedding", (), {"values": [0.1, 0.2, 0.3]})()
|
||||
mock_genai.return_value = type("Response", (), {"embeddings": [emb0]})()
|
||||
|
||||
embedder = GoogleGenAIEmbedding(config)
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
|
||||
|
||||
def test_embed_batch_chunks_over_100_texts(mock_genai, config):
|
||||
def make_chunk_response(**kwargs):
|
||||
chunk = kwargs["contents"]
|
||||
emb = type("Embedding", (), {"values": [0.1, 0.2]})
|
||||
return type("Response", (), {"embeddings": [emb() for _ in chunk]})()
|
||||
|
||||
mock_genai.side_effect = make_chunk_response
|
||||
|
||||
embedder = GoogleGenAIEmbedding(config)
|
||||
texts = [f"text {i}" for i in range(150)]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
assert mock_genai.call_count == 2
|
||||
assert len(result) == 150
|
||||
|
||||
|
||||
def test_embed_batch_strips_newlines(mock_genai, config):
|
||||
emb0 = type("Embedding", (), {"values": [0.1, 0.2, 0.3]})()
|
||||
mock_genai.return_value = type("Response", (), {"embeddings": [emb0]})()
|
||||
|
||||
embedder = GoogleGenAIEmbedding(config)
|
||||
embedder.embed_batch(["line one\nline two"])
|
||||
|
||||
mock_genai.assert_called_once_with(model="test_model", contents=["line one line two"], config=ANY)
|
||||
|
||||
@@ -101,3 +101,71 @@ def test_embed_with_huggingface_base_url():
|
||||
truncate=True,
|
||||
)
|
||||
assert result == [0.1, 0.2, 0.3]
|
||||
|
||||
|
||||
def test_embed_batch_sentence_transformer(mock_sentence_transformer):
|
||||
config = BaseEmbedderConfig()
|
||||
embedder = HuggingFaceEmbedding(config)
|
||||
|
||||
mock_sentence_transformer.encode.return_value = np.array([[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]])
|
||||
|
||||
texts = ["First text.", "Second text."]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
mock_sentence_transformer.encode.assert_called_once_with(texts, convert_to_numpy=True)
|
||||
assert result == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
def test_embed_batch_empty_list_sentence_transformer(mock_sentence_transformer):
|
||||
config = BaseEmbedderConfig()
|
||||
embedder = HuggingFaceEmbedding(config)
|
||||
|
||||
result = embedder.embed_batch([])
|
||||
|
||||
assert result == []
|
||||
mock_sentence_transformer.encode.assert_not_called()
|
||||
|
||||
|
||||
def test_embed_batch_base_url():
|
||||
config = BaseEmbedderConfig(huggingface_base_url="http://localhost:8080", model="my-custom-model")
|
||||
with patch("mem0.embeddings.huggingface.OpenAI") as mock_openai:
|
||||
mock_client = Mock()
|
||||
mock_openai.return_value = mock_client
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_item1 = Mock(index=1, embedding=[0.4, 0.5, 0.6])
|
||||
mock_client.embeddings.create.return_value = Mock(data=[mock_item0, mock_item1])
|
||||
|
||||
embedder = HuggingFaceEmbedding(config)
|
||||
texts = ["First text.", "Second text."]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
mock_client.embeddings.create.assert_called_once_with(
|
||||
input=texts, model="my-custom-model"
|
||||
)
|
||||
assert result == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
def test_embed_batch_count_mismatch_raises_base_url():
|
||||
config = BaseEmbedderConfig(huggingface_base_url="http://localhost:8080", model="my-custom-model")
|
||||
with patch("mem0.embeddings.huggingface.OpenAI") as mock_openai:
|
||||
mock_client = Mock()
|
||||
mock_openai.return_value = mock_client
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_client.embeddings.create.return_value = Mock(data=[mock_item0])
|
||||
|
||||
embedder = HuggingFaceEmbedding(config)
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
|
||||
|
||||
def test_embed_batch_count_mismatch_raises_sentence_transformer(mock_sentence_transformer):
|
||||
config = BaseEmbedderConfig()
|
||||
embedder = HuggingFaceEmbedding(config)
|
||||
|
||||
mock_sentence_transformer.encode.return_value = np.array([[0.1, 0.2, 0.3]])
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
|
||||
@@ -6,6 +6,7 @@ from mem0.configs.embeddings.base import BaseEmbedderConfig
|
||||
from mem0.embeddings.lmstudio import LMStudioEmbedding
|
||||
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_lm_studio_client():
|
||||
with patch("mem0.embeddings.lmstudio.OpenAI") as mock_openai:
|
||||
@@ -27,3 +28,55 @@ def test_embed_text(mock_lm_studio_client):
|
||||
)
|
||||
|
||||
assert embedding == [0.1, 0.2, 0.3, 0.4, 0.5]
|
||||
|
||||
|
||||
def test_embed_batch_single_call(mock_lm_studio_client):
|
||||
config = BaseEmbedderConfig(model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf", embedding_dims=512)
|
||||
embedder = LMStudioEmbedding(config)
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_item1 = Mock(index=1, embedding=[0.4, 0.5, 0.6])
|
||||
mock_lm_studio_client.embeddings.create.return_value = Mock(data=[mock_item0, mock_item1])
|
||||
|
||||
texts = ["First text.", "Second text."]
|
||||
embeddings = embedder.embed_batch(texts)
|
||||
|
||||
mock_lm_studio_client.embeddings.create.assert_called_once_with(
|
||||
input=texts, model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf"
|
||||
)
|
||||
assert embeddings == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
def test_embed_batch_empty_list(mock_lm_studio_client):
|
||||
config = BaseEmbedderConfig(model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf", embedding_dims=512)
|
||||
embedder = LMStudioEmbedding(config)
|
||||
|
||||
result = embedder.embed_batch([])
|
||||
|
||||
assert result == []
|
||||
mock_lm_studio_client.embeddings.create.assert_not_called()
|
||||
|
||||
|
||||
def test_embed_batch_strips_newlines(mock_lm_studio_client):
|
||||
config = BaseEmbedderConfig(model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf", embedding_dims=512)
|
||||
embedder = LMStudioEmbedding(config)
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_lm_studio_client.embeddings.create.return_value = Mock(data=[mock_item0])
|
||||
|
||||
embedder.embed_batch(["line one\nline two"])
|
||||
|
||||
mock_lm_studio_client.embeddings.create.assert_called_once_with(
|
||||
input=["line one line two"], model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf"
|
||||
)
|
||||
|
||||
|
||||
def test_embed_batch_count_mismatch_raises(mock_lm_studio_client):
|
||||
config = BaseEmbedderConfig(model="nomic-embed-text-v1.5-GGUF/nomic-embed-text-v1.5.f16.gguf", embedding_dims=512)
|
||||
embedder = LMStudioEmbedding(config)
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_lm_studio_client.embeddings.create.return_value = Mock(data=[mock_item0])
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
|
||||
@@ -0,0 +1,67 @@
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
from mem0.configs.embeddings.base import BaseEmbedderConfig
|
||||
from mem0.embeddings.together import TogetherEmbedding
|
||||
|
||||
|
||||
@pytest.fixture
|
||||
def mock_together_client():
|
||||
with patch("mem0.embeddings.together.Together") as mock_together:
|
||||
mock_client = Mock()
|
||||
mock_together.return_value = mock_client
|
||||
yield mock_client
|
||||
|
||||
|
||||
def test_embed_text(mock_together_client):
|
||||
config = BaseEmbedderConfig(model="togethercomputer/m2-bert-80M-8k-retrieval", embedding_dims=768)
|
||||
embedder = TogetherEmbedding(config)
|
||||
|
||||
mock_together_client.embeddings.create.return_value = Mock(data=[Mock(embedding=[0.1, 0.2, 0.3, 0.4, 0.5])])
|
||||
|
||||
text = "Sample text to embed."
|
||||
embedding = embedder.embed(text)
|
||||
|
||||
mock_together_client.embeddings.create.assert_called_once_with(
|
||||
model="togethercomputer/m2-bert-80M-8k-retrieval", input=text
|
||||
)
|
||||
assert embedding == [0.1, 0.2, 0.3, 0.4, 0.5]
|
||||
|
||||
|
||||
def test_embed_batch_single_call(mock_together_client):
|
||||
config = BaseEmbedderConfig(model="togethercomputer/m2-bert-80M-8k-retrieval", embedding_dims=768)
|
||||
embedder = TogetherEmbedding(config)
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_item1 = Mock(index=1, embedding=[0.4, 0.5, 0.6])
|
||||
mock_together_client.embeddings.create.return_value = Mock(data=[mock_item0, mock_item1])
|
||||
|
||||
texts = ["First text.", "Second text."]
|
||||
embeddings = embedder.embed_batch(texts)
|
||||
|
||||
mock_together_client.embeddings.create.assert_called_once_with(
|
||||
model="togethercomputer/m2-bert-80M-8k-retrieval", input=texts
|
||||
)
|
||||
assert embeddings == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
def test_embed_batch_empty_list(mock_together_client):
|
||||
config = BaseEmbedderConfig(model="togethercomputer/m2-bert-80M-8k-retrieval", embedding_dims=768)
|
||||
embedder = TogetherEmbedding(config)
|
||||
|
||||
result = embedder.embed_batch([])
|
||||
|
||||
assert result == []
|
||||
mock_together_client.embeddings.create.assert_not_called()
|
||||
|
||||
|
||||
def test_embed_batch_count_mismatch_raises(mock_together_client):
|
||||
config = BaseEmbedderConfig(model="togethercomputer/m2-bert-80M-8k-retrieval", embedding_dims=768)
|
||||
embedder = TogetherEmbedding(config)
|
||||
|
||||
mock_item0 = Mock(index=0, embedding=[0.1, 0.2, 0.3])
|
||||
mock_together_client.embeddings.create.return_value = Mock(data=[mock_item0])
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
@@ -1,4 +1,4 @@
|
||||
from unittest.mock import Mock, patch
|
||||
from unittest.mock import ANY, Mock, patch
|
||||
|
||||
import pytest
|
||||
|
||||
@@ -159,3 +159,122 @@ def test_invalid_memory_action(mock_text_embedding_model, mock_config):
|
||||
|
||||
with pytest.raises(ValueError):
|
||||
embedder.embed("Hello world", memory_action="invalid_action")
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_single_call(mock_text_embedding_model, mock_os_environ, mock_config):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
mock_emb0 = Mock(values=[0.1, 0.2, 0.3])
|
||||
mock_emb1 = Mock(values=[0.4, 0.5, 0.6])
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.return_value = [mock_emb0, mock_emb1]
|
||||
|
||||
texts = ["First text.", "Second text."]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.assert_called_once_with(
|
||||
texts=ANY, output_dimensionality=256
|
||||
)
|
||||
assert result == [[0.1, 0.2, 0.3], [0.4, 0.5, 0.6]]
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_empty_list(mock_text_embedding_model, mock_os_environ, mock_config):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
result = embedder.embed_batch([])
|
||||
|
||||
assert result == []
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.assert_not_called()
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_count_mismatch_raises(mock_text_embedding_model, mock_os_environ, mock_config):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.return_value = [Mock(values=[0.1, 0.2, 0.3])]
|
||||
|
||||
with pytest.raises(ValueError, match="returned 1 embeddings for 2 texts"):
|
||||
embedder.embed_batch(["first text", "second text"])
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingInput")
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_default_memory_action_uses_add(
|
||||
mock_text_embedding_model, mock_text_embedding_input, mock_os_environ, mock_config
|
||||
):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
mock_config.return_value.memory_add_embedding_type = None
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.return_value = [Mock(values=[0.1, 0.2])]
|
||||
|
||||
embedder.embed_batch(["some text"]) # no memory_action — default "add"
|
||||
|
||||
mock_text_embedding_input.assert_called_once_with(text="some text", task_type="RETRIEVAL_DOCUMENT")
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingInput")
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_none_memory_action_uses_default(
|
||||
mock_text_embedding_model, mock_text_embedding_input, mock_os_environ, mock_config
|
||||
):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.return_value = [Mock(values=[0.1, 0.2])]
|
||||
|
||||
embedder.embed_batch(["some text"], memory_action=None)
|
||||
|
||||
mock_text_embedding_input.assert_called_once_with(text="some text", task_type="SEMANTIC_SIMILARITY")
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_invalid_memory_action_raises(mock_text_embedding_model, mock_os_environ, mock_config):
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
with pytest.raises(ValueError, match="Invalid memory action"):
|
||||
embedder.embed_batch(["some text"], memory_action="invalid_action")
|
||||
|
||||
|
||||
@patch("mem0.embeddings.vertexai.TextEmbeddingModel")
|
||||
def test_embed_batch_chunking_triggers_two_api_calls(mock_text_embedding_model, mock_os_environ, mock_config):
|
||||
"""300 texts must produce exactly 2 get_embeddings calls (chunks of 250 and 50)."""
|
||||
mock_config.return_value.model = "gemini-embedding-001"
|
||||
mock_config.return_value.embedding_dims = 256
|
||||
|
||||
config = mock_config()
|
||||
embedder = VertexAIEmbedding(config)
|
||||
|
||||
def make_chunk_response(texts, output_dimensionality):
|
||||
return [Mock(values=[0.1, 0.2]) for _ in texts]
|
||||
|
||||
mock_text_embedding_model.from_pretrained.return_value.get_embeddings.side_effect = make_chunk_response
|
||||
|
||||
texts = [f"text {i}" for i in range(300)]
|
||||
result = embedder.embed_batch(texts)
|
||||
|
||||
assert mock_text_embedding_model.from_pretrained.return_value.get_embeddings.call_count == 2
|
||||
assert len(result) == 300
|
||||
|
||||
Reference in New Issue
Block a user