From 29d131f7aa7e493b190f6bbd215aeff9ca453607 Mon Sep 17 00:00:00 2001
From: Hrushikesh Yadav <136978914+HrushiYadav@users.noreply.github.com>
Date: Mon, 22 Jun 2026 12:05:28 +0530
Subject: [PATCH] fix(chroma): return None instead of {} from
 _generate_where_clause for empty filters (#5713)

---
 mem0/vector_stores/chroma.py       |  4 ++--
 tests/vector_stores/test_chroma.py | 12 +++++++++---
 2 files changed, 11 insertions(+), 5 deletions(-)

diff --git a/mem0/vector_stores/chroma.py b/mem0/vector_stores/chroma.py
index b70bd5fc5..0d399aad7 100644
--- a/mem0/vector_stores/chroma.py
+++ b/mem0/vector_stores/chroma.py
@@ -258,7 +258,7 @@ class ChromaDB(VectorStoreBase):
             dict[str, any]: Properly formatted where clause for ChromaDB.
         """
         if where is None:
-            return {}
+            return None
         
         def convert_condition(key: str, value: any) -> dict:
             """Convert universal filter format to ChromaDB format."""
@@ -352,7 +352,7 @@ class ChromaDB(VectorStoreBase):
         
         # Return appropriate format based on number of conditions
         if len(processed_filters) == 0:
-            return {}
+            return None
         elif len(processed_filters) == 1:
             return processed_filters[0]
         else:
diff --git a/tests/vector_stores/test_chroma.py b/tests/vector_stores/test_chroma.py
index ffa28dbde..bdea18602 100644
--- a/tests/vector_stores/test_chroma.py
+++ b/tests/vector_stores/test_chroma.py
@@ -244,12 +244,18 @@ def test_generate_where_clause_single_filter():
 
 
 def test_generate_where_clause_no_filters():
-    """Test _generate_where_clause with no filters."""
+    """Test _generate_where_clause with no filters returns None."""
     result = ChromaDB._generate_where_clause(None)
-    assert result == {}
+    assert result is None
 
     result = ChromaDB._generate_where_clause({})
-    assert result == {}
+    assert result is None
+
+
+def test_generate_where_clause_all_wildcards_returns_none():
+    """All-wildcard filters must return None, not {}, to avoid ChromaDB ValueError."""
+    result = ChromaDB._generate_where_clause({"user_id": "*"})
+    assert result is None
 
 
 def test_generate_where_clause_non_string_values():