From 1584e24d6e3fbf65ab947e38d45ace57bddefb7b Mon Sep 17 00:00:00 2001 From: kartik-mem0 Date: Mon, 16 Mar 2026 14:18:45 +0530 Subject: [PATCH] fix: skip telemetry vector store init when MEM0_TELEMETRY is disabled The mem0migrations vector store was always initialized regardless of the MEM0_TELEMETRY setting, creating unnecessary connections and collections on remote vector stores for users who opted out. Closes #4200 Co-Authored-By: Claude Opus 4.6 (1M context) --- mem0/memory/main.py | 67 +++++++++++++++++++++++---------------------- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git a/mem0/memory/main.py b/mem0/memory/main.py index 99bc0b1e5..06e6b5976 100644 --- a/mem0/memory/main.py +++ b/mem0/memory/main.py @@ -24,7 +24,7 @@ from mem0.exceptions import ValidationError as Mem0ValidationError from mem0.memory.base import MemoryBase from mem0.memory.setup import mem0_dir, setup_config from mem0.memory.storage import SQLiteManager -from mem0.memory.telemetry import capture_event +from mem0.memory.telemetry import MEM0_TELEMETRY, capture_event from mem0.memory.utils import ( extract_json, get_fact_retrieval_messages, @@ -37,8 +37,8 @@ from mem0.utils.factory import ( EmbedderFactory, GraphStoreFactory, LlmFactory, - VectorStoreFactory, RerankerFactory, + VectorStoreFactory, ) # Suppress SWIG deprecation warnings globally @@ -204,32 +204,33 @@ class Memory(MemoryBase): self.enable_graph = True else: self.graph = None - # Create telemetry config manually to avoid deepcopy issues with thread locks - telemetry_config_dict = {} - if hasattr(self.config.vector_store.config, 'model_dump'): - # For pydantic models - telemetry_config_dict = self.config.vector_store.config.model_dump() - else: - # For other objects, manually copy common attributes - for attr in ['host', 'port', 'path', 'api_key', 'index_name', 'dimension', 'metric']: - if hasattr(self.config.vector_store.config, attr): - telemetry_config_dict[attr] = getattr(self.config.vector_store.config, attr) + if MEM0_TELEMETRY: + # Create telemetry config manually to avoid deepcopy issues with thread locks + telemetry_config_dict = {} + if hasattr(self.config.vector_store.config, 'model_dump'): + # For pydantic models + telemetry_config_dict = self.config.vector_store.config.model_dump() + else: + # For other objects, manually copy common attributes + for attr in ['host', 'port', 'path', 'api_key', 'index_name', 'dimension', 'metric']: + if hasattr(self.config.vector_store.config, attr): + telemetry_config_dict[attr] = getattr(self.config.vector_store.config, attr) - # Override collection name for telemetry - telemetry_config_dict['collection_name'] = "mem0migrations" + # Override collection name for telemetry + telemetry_config_dict['collection_name'] = "mem0migrations" - # Set path for file-based vector stores - telemetry_config = _safe_deepcopy_config(self.config.vector_store.config) - if self.config.vector_store.provider in ["faiss", "qdrant"]: - provider_path = f"migrations_{self.config.vector_store.provider}" - telemetry_config_dict['path'] = os.path.join(mem0_dir, provider_path) - os.makedirs(telemetry_config_dict['path'], exist_ok=True) + # Set path for file-based vector stores + telemetry_config = _safe_deepcopy_config(self.config.vector_store.config) + if self.config.vector_store.provider in ["faiss", "qdrant"]: + provider_path = f"migrations_{self.config.vector_store.provider}" + telemetry_config_dict['path'] = os.path.join(mem0_dir, provider_path) + os.makedirs(telemetry_config_dict['path'], exist_ok=True) - # Create the config object using the same class as the original - telemetry_config = self.config.vector_store.config.__class__(**telemetry_config_dict) - self._telemetry_vector_store = VectorStoreFactory.create( - self.config.vector_store.provider, telemetry_config - ) + # Create the config object using the same class as the original + telemetry_config = self.config.vector_store.config.__class__(**telemetry_config_dict) + self._telemetry_vector_store = VectorStoreFactory.create( + self.config.vector_store.provider, telemetry_config + ) capture_event("mem0.init", self, {"sync_type": "sync"}) @classmethod @@ -1272,14 +1273,14 @@ class AsyncMemory(MemoryBase): else: self.graph = None - telemetry_config = _safe_deepcopy_config(self.config.vector_store.config) - telemetry_config.collection_name = "mem0migrations" - if self.config.vector_store.provider in ["faiss", "qdrant"]: - provider_path = f"migrations_{self.config.vector_store.provider}" - telemetry_config.path = os.path.join(mem0_dir, provider_path) - os.makedirs(telemetry_config.path, exist_ok=True) - self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config) - + if MEM0_TELEMETRY: + telemetry_config = _safe_deepcopy_config(self.config.vector_store.config) + telemetry_config.collection_name = "mem0migrations" + if self.config.vector_store.provider in ["faiss", "qdrant"]: + provider_path = f"migrations_{self.config.vector_store.provider}" + telemetry_config.path = os.path.join(mem0_dir, provider_path) + os.makedirs(telemetry_config.path, exist_ok=True) + self._telemetry_vector_store = VectorStoreFactory.create(self.config.vector_store.provider, telemetry_config) capture_event("mem0.init", self, {"sync_type": "async"}) @classmethod